feat: ban deposits interop#11454
feat: ban deposits interop#11454skeletor-spaceman merged 22 commits intoethereum-optimism:feat/ban-deposits-interopfrom
Conversation
* refactor: not cross l2 inbox error
* refactor: not cross l2 inbox error
…nd/optimism into feat/ban-deposits-interop
* feat: add is deposit test
* fix: stick to natspec standards
This reverts commit e162361.
…mism/optimism into feat/ban-deposits-interop
* refactor: move the isthmus test logic to the l1 block test contract
* chore: remove unused imports
…mism/optimism into feat/ban-deposits-interop
|
To be backwards compatible, we should follow this document: https://github.com/ethereum-optimism/design-docs/blob/main/smart-contract-feature-development.md This would mean we create a L1BlockInterop contract (we may already have one) |
|
Did you mean to make this just a benchmark PR? If so this looks good to me |
Yes! The idea is to add it that branch, so it can be reviewed on this PR: #11362 |
Yes, this was also pushed to that same branch. The But of course, if something is wrong or missing, let us know so we can push the changes |
Ah ok, apologies if i misread something! Thank you for breaking this up into a small PR, i mistook this as for onto develop |
da494fd
into
ethereum-optimism:feat/ban-deposits-interop
Description
Added benchmark for the
setValuesEcotone()andsetValuesIsthmus()functions.Additional context
#11362 (review)